Split SPIPinControl() function #338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trim all of the trailing whitespace from all files in the in the `lib/tiam1808` directory. This way, if we want to modify a file in the future, we don't have to deal with it.
Split SPIPinControl() into SPIPinControlGet() and SPIPinControlSet() functions. Having to pass a pointer to flags to set a value was awkward and the read/write flag parameter made it difficult to know if we were reading or writing. And any function that does two completely different things based on a boolean flag is a code smell.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bothered me when doing code reviews because it was so awkward, so let's clean it up.
Also fix all of the trailing whitespace issues in the tiam1808 library while we are cleaning things up.